c8e22f6723
Add Shutdown method to registry.Registry ( #4338 )
2024-05-01 15:05:44 +01:00
16a305ebaf
Add registry.Shutdown method for graceful shutdown of embedded registry
...
Signed-off-by: Robin Ketelbuters <robin.ketelbuters@gmail.com>
2024-04-29 20:18:58 +02:00
e0795fcfe3
add bounded concurrency for tag lookup and untag ( #4329 )
2024-04-26 19:59:59 +01:00
a2afe23f38
add concurrency limits for tag lookup and untag
...
Harbor is using the distribution for it's (harbor-registry) registry component.
The harbor GC will call into the registry to delete the manifest, which in turn
then does a lookup for all tags that reference the deleted manifest.
To find the tag references, the registry will iterate every tag in the repository
and read it's link file to check if it matches the deleted manifest (i.e. to see
if uses the same sha256 digest). So, the more tags in repository, the worse the
performance will be (as there will be more s3 API calls occurring for the tag
directory lookups and tag file reads).
Therefore, we can use concurrent lookup and untag to optimize performance as described in https://github.com/goharbor/harbor/issues/12948 .
P.S. This optimization was originally contributed by @Antiarchitect, now I would like to take it over.
Thanks @Antiarchitect's efforts with PR https://github.com/distribution/distribution/pull/3890 .
Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
2024-04-26 22:32:21 +08:00
a5882d6646
vendor: update manifest dependencies
...
Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
2024-04-26 22:22:49 +08:00
47a9dac250
fix: ignore error of manifest tag path not found in gc ( #4331 )
2024-04-25 10:25:54 -07:00
112156321f
fix: ignore error of manifest tag path not found in gc
...
it is reasonable to ignore the error that the manifest tag path does not exist when querying
all tags of the specified repository when executing gc.
Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
2024-04-25 17:13:06 +08:00
e6d1d182bf
Allow setting s3 forcepathstyle without regionendpoint ( #4291 )
2024-04-24 08:34:01 +01:00
03e58dfcf8
chore: fix some typos in comments ( #4335 )
2024-04-24 08:33:32 +01:00
d61d8ebc16
build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 ( #4333 )
2024-04-23 16:18:48 +01:00
2fe3442035
chore: fix some typos in comments
...
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
2024-04-23 17:48:53 +08:00
e8ea4e5951
chore: fix some typos in comments ( #4332 )
2024-04-23 09:03:51 +01:00
bdd3d31fae
proxy: Do not configure HTTP secret for proxy registry ( #4305 )
2024-04-23 08:17:50 +01:00
e0a1ce14a8
chore: fix some typos in comments
...
Signed-off-by: goodactive <goodactive@qq.com>
2024-04-23 12:04:03 +08:00
df98374764
Fix garbage-collect --delete-untagged to handle schema 2 manifest list and OCI image index ( #4285 )
2024-04-21 09:18:41 +01:00
601b37d98b
Handle OCI image index and V2 manifest list during garbage collection
...
Signed-off-by: Anthony Ramahay <thewolt@gmail.com>
2024-04-20 16:41:50 +02:00
2db0a598cc
build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.20.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.20.0...v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-19 12:59:08 +00:00
bc6e81e1b9
Add Go 1.22 support to CI ( #4314 )
2024-04-08 12:15:39 +01:00
0947c654e9
chore: bump distriution/reference dependency ( #4312 )
2024-04-08 19:13:55 +08:00
dde4f2a6db
chore: remove repetitive words in comments ( #4313 )
2024-04-08 12:04:43 +01:00
8654a0ee45
Allow setting s3 forcepathstyle without regionendpoint
...
Currently, the `forcepathstyle` parameter for the s3 storage driver is
considered only if the `regionendpoint` parameter is set. Since setting
a region endpoint explicitly is discouraged with AWS s3, it is not clear
how to enforce path style URLs with AWS s3.
This also means, that the default value (true) only applies if a region
endpoint is configured.
This change makes sure we always forward the `forcepathstyle` parameter
to the aws-sdk if present in the config. This is a breaking change where
a `regionendpoint` is configured but no explicit `forcepathstyle` value
is set.
Signed-off-by: Benjamin Schanzel <benjamin.schanzel@bmw.de>
2024-04-08 12:45:26 +02:00
0d1792f55f
build(deps): bump fossa-contrib/fossa-action from 2 to 3 ( #4232 )
2024-04-02 10:11:05 +01:00
f525c27f55
build(deps): bump ossf/scorecard-action from 2.0.6 to 2.3.1 ( #4231 )
2024-04-02 10:10:51 +01:00
21c718d58c
Add Go 1.22 support to CI
...
This change adds Go 1.22 to the Go version matrix in CI and updates all
Dockerfiles to use Go 1.21.8.
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
2024-03-27 15:59:13 +00:00
2446e1102d
chore: remove repetitive words in comments
...
Signed-off-by: xiaoxiangxianzi <zhaoyizheng@outlook.com>
2024-03-27 17:34:22 +08:00
167d7996be
chore: bump distriution/reference dependency
...
We've made a new release https://github.com/distribution/reference
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
2024-03-26 20:19:28 +00:00
9d36624563
Upgrade Scorecard Action version to fix error ( #4311 )
2024-03-26 14:49:01 +00:00
fdbb3a8288
fix: upgrade scorecard version
...
Signed-off-by: Joyce Brum <joycebrum@google.com>
2024-03-26 11:28:03 -03:00
94146f53d8
Don't try to parse error responses with no body ( #4307 )
2024-03-20 16:36:20 +00:00
e8820b2564
Don't try to parse error responses with no body
...
HEAD requests for instance return no body while still having all the relevant Content-Type headers set, causing unnecessary parsing errors. This skips further parsing for all requests that don't have any body to begin with.
Signed-off-by: Markus Thömmes <markusthoemmes@me.com>
2024-03-20 11:46:14 +01:00
3cb985cac0
Initialize proxy prometheus counters values to 0 ( #4283 )
2024-03-18 14:34:28 +00:00
1e3de58231
Update go versions ( #4303 )
2024-03-18 14:08:00 +00:00
7c7517493c
build(deps): bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 ( #4297 )
2024-03-17 10:38:34 +00:00
127fa7e057
proxy: Do not configure HTTP secret for proxy registry
...
Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
2024-03-15 18:27:08 +02:00
1cb89e3e0e
Update go versions
...
Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
2024-03-15 10:57:53 +02:00
3783a79518
build(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 ( #4301 )
2024-03-14 11:13:50 +00:00
cb2b51cac9
build(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0
...
Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0.
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-03-13 23:16:02 +00:00
d9815da9cb
Support redirects in gcs storage with default credentials ( #4295 )
2024-03-11 22:29:57 +00:00
de450c903a
update: support redirects in gcs storage with default credentials
...
Signed-off-by: Tadeusz Dudkiewicz <tadeusz.dudkiewicz@rtbhouse.com>
2024-03-11 21:05:03 +01:00
1c5fe22dec
build(deps): bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3
...
Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose ) from 3.0.1 to 3.0.3.
- [Release notes](https://github.com/go-jose/go-jose/releases )
- [Changelog](https://github.com/go-jose/go-jose/blob/v3.0.3/CHANGELOG.md )
- [Commits](https://github.com/go-jose/go-jose/compare/v3.0.1...v3.0.3 )
---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v3
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-03-07 23:01:05 +00:00
663b430ccc
fix: typo ( #4296 )
2024-03-07 10:18:20 +00:00
6465b4cd08
fix: typo
...
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
2024-03-07 10:08:58 +08:00
5c662eb1c2
Standardize OTEL error logging format to match application logs ( #4292 )
2024-03-05 17:22:26 +00:00
63eb22d74b
Fix: ‘autoRedirect’ hardcode ‘https’ scheme
...
Signed-off-by: icefed <zlwangel@gmail.com>
2024-03-05 20:50:09 +08:00
71a069dc38
Standardize OTEL error logging format to match application logs
...
Signed-off-by: gotgelf <gotgelf@gmail.com>
2024-03-05 07:22:10 +01:00
51a72c2aef
[otel-tracing] Added Tracing to Base package (driver) ( #4196 )
2024-03-04 17:06:07 +00:00
f690b3ebe2
Added Open Telemetry Tracing to Filesystem package
...
Signed-off-by: gotgelf <gotgelf@gmail.com>
2024-03-04 13:31:22 +01:00
95077fda37
fix: typo ( #4290 )
2024-03-04 09:03:44 +00:00
a4918b67bb
fix: typo
...
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
2024-03-04 11:00:08 +08:00
38beeee2c8
Update notifications.md ( #4287 )
2024-03-01 22:23:16 +00:00
Milos Gajdos