github.com/distribution
1
0
Fork 0
mirror of https://github.com/distribution/distribution synced 2024-12-25 15:05:51 +01:00
Code Releases Wiki Activity

fix logic for handling regionEndpoint (#4341)

Browse Source
This commit is contained in:
Milos Gajdos 2024-07-18 22:56:58 +01:00 committed by GitHub
commit 252619876a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
registry/storage/driver/s3-aws/s3.go
View File

@ -223,12 +223,13 @@ func FromParameters(ctx context.Context, parameters map[string]interface{}) (*Dr
}
regionName := parameters["region"]
if regionName == nil || fmt.Sprint(regionName) == "" {
return nil, fmt.Errorf("no region parameter provided")
}
region := fmt.Sprint(regionName)
// Don't check the region value if a custom endpoint is provided.
if regionEndpoint == "" {
if regionName == nil || region == "" {
return nil, fmt.Errorf("no region parameter provided")
}
if _, ok := validRegions[region]; !ok {
return nil, fmt.Errorf("invalid region provided: %v", region)
}