1
0
mirror of https://github.com/verdaccio/verdaccio.git synced 2024-11-13 03:35:52 +01:00
Commit Graph

6 Commits

Author SHA1 Message Date
Will Smythe
eb7a8e3528 fix(api): return 503 to npm/yarn on uplink connection timeout (#1331)
fix  #1328 and #720

Type: bug

The following has been addressed in the PR:

Instead of returning a 404 (Not Found) when npm, yarn, etc requests a package and the package cannot be acquired from an uplink due to a connection timeout, socket timeout, or connection reset problem, a 503 (service unavailable) is returned by Verdaccio instead. In limited testing of a few versions of npm and yarn, both of these clients correctly attempt to retry the request when a 503 is returned.

Added functional tests to verify the behavior (this adds a dev dependency on nock, which provides HTTP request mocking

Description:

This resolves issue #1328 and #720, and ensures npm/yarn install commands don't fail immediately when there is an intermittent network timeout problem with an uplink. Instead Verdaccio will appropriately respond to the client with a 503. A 404 response (current behavior) incorrectly tells the client that the package does not exist (which may or may not be true) and to not try again.
2019-06-13 21:42:01 +02:00
Juan Picado @jotadeveloper
90e700ce78
refactor: dist-tags-merge test 2018-06-23 20:59:35 +02:00
Juan Picado @jotadeveloper
a1a70c973f
refactor: middleware plugins
add es6 transpiled use case
2018-06-23 20:59:24 +02:00
Juan Picado @jotadeveloper
d8455dd15a
refactor: using constants
relocate uplink token test to unit test
2018-06-23 20:57:20 +02:00
Juan Picado @jotadeveloper
9242d498d7
refactor: functional testing
* server now are executed in the jest setup phase
* disable one snapshot
2018-06-23 20:57:16 +02:00
Juan Picado @jotadeveloper
b28e6f737b
refactor: functional testing relocation
functional testing runs in a different process
2018-06-23 20:57:13 +02:00