github.com/verdaccio
1
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2025-02-21 07:29:37 +01:00
Code Releases Wiki Activity

up-storage: make streaming requests without buffering

Browse Source
This commit is contained in:
Alex Kocharin 2015-05-16 19:33:06 +03:00
parent 6b6247b009
commit f1bb9f83e6
1 changed files with 28 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
lib/up-storage.js
View File

@ -2,7 +2,6 @@ var Error = require('http-errors')
var request = require('request') var request = require('request')
var Stream = require('stream') var Stream = require('stream')
var URL = require('url') var URL = require('url')
var zlib = require('zlib')
var parse_interval = require('./config').parse_interval var parse_interval = require('./config').parse_interval
var Logger = require('./logger') var Logger = require('./logger')
var MyStreams = require('./streams') var MyStreams = require('./streams')
@ -127,34 +126,13 @@ Storage.prototype.request = function(options, cb) {
headers['Content-Type'] = headers['Content-Type'] || 'application/json' headers['Content-Type'] = headers['Content-Type'] || 'application/json'
} }
var req = request({ var request_callback = cb ? (function (err, res, body) {
url : uri,
method : method,
headers : headers,
body : json,
ca : this.ca,
proxy : this.proxy,
encoding : null,
timeout : this.timeout,
}, function(err, res, body) {
var error var error
var res_length = err ? 0 : body.length var res_length = err ? 0 : body.length
do_gunzip(function() {
do_decode() do_decode()
do_log() do_log()
if (cb) cb(err, res, body) cb(err, res, body)
})
function do_gunzip(cb) {
if (err) return cb()
if (res.headers['content-encoding'] !== 'gzip') return cb()
zlib.gunzip(body, function(er, buf) {
if (er) err = er
body = buf
return cb()
})
}
function do_decode() { function do_decode() {
if (err) { if (err) {
@ -196,7 +174,19 @@ Storage.prototype.request = function(options, cb) {
} }
}, message) }, message)
} }
}) }) : undefined
var req = request({
url : uri,
method : method,
headers : headers,
body : json,
ca : this.ca,
proxy : this.proxy,
encoding : null,
gzip : true,
timeout : this.timeout,
}, request_callback)
var status_called = false var status_called = false
req.on('response', function(res) { req.on('response', function(res) {
@ -204,6 +194,17 @@ Storage.prototype.request = function(options, cb) {
status_called = true status_called = true
self.status_check(true) self.status_check(true)
} }
if (!request_callback) {
;(function do_log() {
var message = '@{!status}, req: \'@{request.method} @{request.url}\' (streaming)'
self.logger.warn({
request : { method: method, url: uri },
level : 35, // http
status : res != null ? res.statusCode : 'ERR',
}, message)
})()
}
}) })
req.on('error', function(_err) { req.on('error', function(_err) {
if (!req._sinopia_aborted && !status_called) { if (!req._sinopia_aborted && !status_called) {