github.com
/
verdaccio
mirror of https://github.com/verdaccio/verdaccio.git
1
0
Fork 0
Code Releases Wiki Activity

Merge pull request #1240 from verdaccio/fix-1191 

fix: overrides existing package to zero bytes file #1191
This commit is contained in:
Juan Picado @jotadeveloper 2019-02-25 19:24:27 +01:00 committed by GitHub
parent b92805522c 3c1f49bf73
commit d105573665
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -15,7 +15,7 @@
"verdaccio": "./bin/verdaccio"
},
"dependencies": {
"@verdaccio/local-storage": "1.1.6",
"@verdaccio/local-storage": "1.1.7",
"@verdaccio/streams": "1.0.0",
"JSONStream": "1.3.5",
"async": "3.0.1-0",

4
src/lib/local-storage.js
View File

@ -222,7 +222,9 @@ class LocalStorage implements IStorage {
metadata = cleanUpReadme(metadata);
metadata.contributors = normalizeContributors(metadata.contributors);
if (data.versions[version] != null) {
const hasVersion = data.versions[version] != null;
if (hasVersion) {
return cb( ErrorCode.getConflict() );
}

6
test/unit/api/local-storage.spec.js
View File

@ -364,16 +364,10 @@ describe('LocalStorage', () => {
test('should fails on add a duplicated new tarball ', (done) => {
const tarballData = JSON.parse(readMetadata('addTarball'));
const stream = storage.addTarball(pkgName, tarballName);
let spy;
// $FlowFixMe
spy = jest.spyOn(stream && stream._readableState && stream._readableState.pipes, 'abort');
stream.on('error', (err) => {
expect(err).not.toBeNull();
expect(err.statusCode).toEqual(HTTP_STATUS.CONFLICT);
expect(err.message).toMatch(/this package is already present/);
});
stream.on('success', function(){
expect(spy).toHaveBeenCalled();
done();
});
stream.end(new Buffer(tarballData.data, 'base64'));

8
yarn.lock
View File

@ -245,10 +245,10 @@
lockfile "1.0.4"
lodash "4.17.11"
"@verdaccio/local-storage@1.1.6":
version "1.1.6"
resolved "https://registry.npmjs.org/@verdaccio/local-storage/-/local-storage-1.1.6.tgz#961310552d1927178830aa00d9ad3cef1dd1deea"
integrity sha512-rSzugEK6GDenprvnbzR66LSwwpdvXkG7UUJQDQu7dFjlwcCFYJZ9vgOwSU2XJnxFH+ah+ngFIQFB/wTGzzK2gA==
"@verdaccio/local-storage@1.1.7":
version "1.1.7"
resolved "https://registry.npmjs.org/@verdaccio/local-storage/-/local-storage-1.1.7.tgz#63cc812ff0b5a3dd6e5918d239125888567330e9"
integrity sha512-liiB1xUW3+FZSeGinH8FkQ+GJ4s9QUVwJ/LjjgUMjySqb8XiySAsbVzVTZQcXSAYgeL9omCYHfwsyKERkvU1nA==
dependencies:
"@verdaccio/file-locking" "0.0.8"
"@verdaccio/streams" "1.0.0"