github.com
/
verdaccio
mirror of https://github.com/verdaccio/verdaccio.git
1
0
Fork 0
Code Releases Wiki Activity

fix: flow lint errors

This commit is contained in:
Juan Picado @jotadeveloper 2017-12-17 22:50:09 +01:00 committed by juanpicado
parent b494d47eeb
commit ce5af8a004
3 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -18,7 +18,7 @@
"@verdaccio/file-locking": "^0.0.5", "@verdaccio/file-locking": "^0.0.5",
"@verdaccio/local-storage": "^0.0.14", "@verdaccio/local-storage": "^0.0.14",
"@verdaccio/streams": "^0.0.2", "@verdaccio/streams": "^0.0.2",
"@verdaccio/types": "^0.0.8", "@verdaccio/types": "^0.0.10",
"JSONStream": "^1.1.1", "JSONStream": "^1.1.1",
"apache-md5": "^1.1.2", "apache-md5": "^1.1.2",
"async": "^2.6.0", "async": "^2.6.0",

2
src/lib/utils.js
View File

@ -143,7 +143,7 @@ function filter_tarball_urls(pkg, req, config) {
* @return {Boolean} whether a package has been tagged * @return {Boolean} whether a package has been tagged
*/ */
function tag_version(data, version, tag) { function tag_version(data, version, tag) {
if (tag) { if (_.isEmpty(tag) === false) {
if (data['dist-tags'][tag] !== version) { if (data['dist-tags'][tag] !== version) {
if (semver.parse(version, true)) { if (semver.parse(version, true)) {
// valid version - store // valid version - store

16
test/unit/local-storage.spec.js
View File

@ -3,6 +3,7 @@ import rimRaf from 'rimraf';
import path from 'path'; import path from 'path';
import LocalStorage from '../../src/lib/local-storage'; import LocalStorage from '../../src/lib/local-storage';
import AppConfig from '../../src/lib/config'; import AppConfig from '../../src/lib/config';
// $FlowFixMe
import configExample from './partials/config'; import configExample from './partials/config';
import Logger, {setup} from '../../src/lib/logger'; import Logger, {setup} from '../../src/lib/logger';
import {readFile} from '../functional/lib/test.utils'; import {readFile} from '../functional/lib/test.utils';
@ -34,13 +35,14 @@ describe('LocalStorage', () => {
describe('LocalStorage::addPackage', () => { describe('LocalStorage::addPackage', () => {
test('should add a package', (done) => { test('should add a package', (done) => {
const metadata = JSON.parse(readMetadata()); const metadata = JSON.parse(readMetadata());
const pkgStoragePath: string = storage._getLocalStorage(pkgName); // $FlowFixMe
const pkgStoragePath = storage._getLocalStorage(pkgName);
rimRaf(pkgStoragePath.path, (err) => { rimRaf(pkgStoragePath.path, (err) => {
expect(err).toBeNull(); expect(err).toBeNull();
storage.addPackage(pkgName, metadata, (err, data) => { storage.addPackage(pkgName, metadata, (err, data) => {
expect(data.version).toMatch(/1.0.0/); expect(data.version).toMatch(/1.0.0/);
expect(data.dist.tarball).toMatch(/npm_test-1.0.0.tgz/); expect(data.dist.tarball).toMatch(/npm_test-1.0.0.tgz/);
expect(data.name).toMatch(pkgName); expect(data.name).toEqual(pkgName);
done(); done();
}); });
}); });
@ -48,14 +50,15 @@ describe('LocalStorage', () => {
test('should add a @scope package', (done) => { test('should add a @scope package', (done) => {
const metadata = JSON.parse(readMetadata()); const metadata = JSON.parse(readMetadata());
const pkgStoragePath: string = storage._getLocalStorage(pkgNameScoped); // $FlowFixMe
const pkgStoragePath = storage._getLocalStorage(pkgNameScoped);
rimRaf(pkgStoragePath.path, (err) => { rimRaf(pkgStoragePath.path, (err) => {
expect(err).toBeNull(); expect(err).toBeNull();
storage.addPackage(pkgNameScoped, metadata, (err, data) => { storage.addPackage(pkgNameScoped, metadata, (err, data) => {
expect(data.version).toMatch(/1.0.0/); expect(data.version).toMatch(/1.0.0/);
expect(data.dist.tarball).toMatch(/npm_test-1.0.0.tgz/); expect(data.dist.tarball).toMatch(/npm_test-1.0.0.tgz/);
expect(data.name).toMatch(pkgName); expect(data.name).toEqual(pkgName);
done(); done();
}); });
}); });
@ -77,7 +80,7 @@ describe('LocalStorage', () => {
test('should add new version without tag', (done) => { test('should add new version without tag', (done) => {
const metadata = JSON.parse(readMetadata('metadata-add-version')); const metadata = JSON.parse(readMetadata('metadata-add-version'));
storage.addVersion(pkgName, '1.0.1', metadata, null, (err, data) => { storage.addVersion(pkgName, '1.0.1', metadata, '', (err, data) => {
expect(err).toBeNull(); expect(err).toBeNull();
expect(data).toBeUndefined(); expect(data).toBeUndefined();
done(); done();
@ -87,7 +90,7 @@ describe('LocalStorage', () => {
test('should fails on add a duplicated version without tag', (done) => { test('should fails on add a duplicated version without tag', (done) => {
const metadata = JSON.parse(readMetadata('metadata-add-version')); const metadata = JSON.parse(readMetadata('metadata-add-version'));
storage.addVersion(pkgName, '1.0.1', metadata, null, (err, data) => { storage.addVersion(pkgName, '1.0.1', metadata, '', (err, data) => {
expect(err).not.toBeNull(); expect(err).not.toBeNull();
expect(err.statusCode).toEqual(409); expect(err.statusCode).toEqual(409);
expect(err.message).toMatch(/this package is already present/); expect(err.message).toMatch(/this package is already present/);
@ -135,6 +138,7 @@ describe('LocalStorage', () => {
test('should add a new tarball', (done) => { test('should add a new tarball', (done) => {
const tarballData = JSON.parse(readMetadata('addTarball')); const tarballData = JSON.parse(readMetadata('addTarball'));
const stream = storage.addTarball(pkgName, tarballName); const stream = storage.addTarball(pkgName, tarballName);
stream.on('error', function(err) { stream.on('error', function(err) {
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();