From 3ca20d0c4e0225c6b9a0b7dbaea75fffe883c190 Mon Sep 17 00:00:00 2001 From: "Juan Picado @jotadeveloper" Date: Wed, 5 Sep 2018 22:10:27 +0200 Subject: [PATCH 1/2] fix: missing properties for default matcher #981 (#982) --- src/lib/config-utils.js | 2 +- test/unit/api/config-utils.spec.js | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/lib/config-utils.js b/src/lib/config-utils.js index d4c1eac98..cd6ccad35 100644 --- a/src/lib/config-utils.js +++ b/src/lib/config-utils.js @@ -107,7 +107,7 @@ export function normalisePackageAccess(packages: PackageList): PackageList { const normalizedPkgs: PackageList = {...packages}; // add a default rule for all packages to make writing plugins easier if (_.isNil(normalizedPkgs['**'])) { - normalizedPkgs['**'] = {}; + normalizedPkgs['**'] = {access: [], publish: []}; } for (let pkg in packages) { diff --git a/test/unit/api/config-utils.spec.js b/test/unit/api/config-utils.spec.js index 667db85b5..6aabb33e9 100644 --- a/test/unit/api/config-utils.spec.js +++ b/test/unit/api/config-utils.spec.js @@ -1,6 +1,7 @@ // @flow import path from 'path'; +import _ from 'lodash'; import {spliceURL} from '../../../src/utils/string'; import {parseConfigFile} from '../../../src/lib/utils'; import { @@ -125,12 +126,14 @@ describe('Config Utilities', () => { const scoped = access[`${PACKAGE_ACCESS.SCOPE}`]; expect(scoped).toBeUndefined(); - // ** should be added by default + // ** should be added by default ** const all = access[`${PACKAGE_ACCESS.ALL}`]; expect(all).toBeDefined(); - expect(all.access).toBeUndefined(); - expect(all.publish).toBeUndefined(); + expect(all.access).toBeDefined(); + expect(_.isArray(all.access)).toBeTruthy(); + expect(all.publish).toBeDefined(); + expect(_.isArray(all.publish)).toBeTruthy(); }); }); From 7b1c7afa7eaac1e31be24f4a2ada57b8e67d4494 Mon Sep 17 00:00:00 2001 From: "Juan Picado @jotadeveloper" Date: Wed, 5 Sep 2018 22:23:11 +0200 Subject: [PATCH 2/2] chore(release): 3.8.0 --- CHANGELOG.md | 15 +++++++++++++++ package.json | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb4279f2d..630025a70 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,21 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. + +# [3.8.0](https://github.com/verdaccio/verdaccio/compare/v3.7.1...v3.8.0) (2018-09-05) + + +### Bug Fixes + +* missing properties for default matcher [#981](https://github.com/verdaccio/verdaccio/issues/981) ([#982](https://github.com/verdaccio/verdaccio/issues/982)) ([3ca20d0](https://github.com/verdaccio/verdaccio/commit/3ca20d0)) + + +### Features + +* exposed rotating-file log for json logging ([#948](https://github.com/verdaccio/verdaccio/issues/948)) ([5ca0ca5](https://github.com/verdaccio/verdaccio/commit/5ca0ca5)) + + + ## [3.7.1](https://github.com/verdaccio/verdaccio/compare/v3.7.0...v3.7.1) (2018-08-28) diff --git a/package.json b/package.json index 3e667e289..1fa943c65 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "verdaccio", - "version": "3.7.1", + "version": "3.8.0", "description": "Private npm repository server", "author": { "name": "Alex Kocharin",