make authentication function async

lib/config.js

@@ -146,9 +146,9 @@ Config.prototype.get_package_setting = function(package, setting) {
 	return undefined
 }
 
-Config.prototype.authenticate = function(user, password) {
-	if (this.users[user] == null) return false
-	return crypto.createHash('sha1').update(password).digest('hex') === this.users[user].password
+Config.prototype.authenticate = function(user, password, cb) {
+	if (this.users[user] == null) return cb(null, false)
+	return cb(null, crypto.createHash('sha1').update(password).digest('hex') === this.users[user].password)
 }
 
 module.exports = Config

lib/index.js

@@ -89,8 +89,8 @@ module.exports = function(config_hash) {
 		next()
 	})
 	app.use(Cats.middleware)
-	app.use(basic_auth(function(user, pass) {
-		return config.authenticate(user, pass)
+	app.use(basic_auth(function(user, pass, cb) {
+		config.authenticate(user, pass, cb)
 	}))
 	app.use(express.json({strict: false, limit: config.max_body_size || '10mb'}))
 	app.use(express.compress())

lib/middleware.js

@@ -76,7 +76,9 @@ module.exports.basic_auth = function basic_auth(callback) {
 		var user = credentials.slice(0, index)
 		  , pass = credentials.slice(index + 1)
 
-		if (callback(user, pass)) {
+		callback(user, pass, function(err, is_ok) {
+			if (err) return next(err)
+			if (is_ok) {
 				req.remoteUser = user
 				next()
 			} else {
@@ -85,6 +87,7 @@ module.exports.basic_auth = function basic_auth(callback) {
 					msg: 'bad username/password, access denied',
 				})
 			}
+		})
 	}
 }