fix: #1191 overrides existing package to 0 bytes file

This commit is contained in:
Juan Picado @jotadeveloper 2019-02-24 10:26:43 +01:00
parent e143b7d0fe
commit 783fbce060
No known key found for this signature in database
GPG Key ID: 18AC54485952D158
3 changed files with 14 additions and 20 deletions

View File

@ -16,7 +16,7 @@
},
"dependencies": {
"@verdaccio/file-locking": "0.0.8",
"@verdaccio/local-storage": "2.0.0-beta.1",
"@verdaccio/local-storage": "2.0.0-beta.2",
"@verdaccio/streams": "2.0.0-beta.0",
"JSONStream": "1.3.5",
"async": "3.0.1-0",

View File

@ -363,16 +363,10 @@ describe('LocalStorage', () => {
test('should fails on add a duplicated new tarball ', (done) => {
const tarballData = JSON.parse(readMetadata('addTarball'));
const stream = storage.addTarball(pkgName, tarballName);
let spy;
// $FlowFixMe
spy = jest.spyOn(stream && stream._readableState && stream._readableState.pipes, 'abort');
stream.on('error', (err) => {
expect(err).not.toBeNull();
expect(err.statusCode).toEqual(HTTP_STATUS.CONFLICT);
expect(err.message).toMatch(/this package is already present/);
});
stream.on('success', function(){
expect(spy).toHaveBeenCalled();
done();
});
stream.end(new Buffer(tarballData.data, 'base64'));

View File

@ -1238,14 +1238,14 @@
lockfile "1.0.4"
lodash "4.17.11"
"@verdaccio/local-storage@2.0.0-beta.1":
version "2.0.0-beta.1"
resolved "https://registry.verdaccio.org/@verdaccio%2flocal-storage/-/local-storage-2.0.0-beta.1.tgz#1aa602b24fa2f6b02d682e5e56b4894112e198e6"
integrity sha512-JpuO0e9DLFItagUqq6EbiaHpbGAql4IREu3ntprfYVrWgdypgcYWS5iwp+Py1Not/Ahv4cYXi+cQ5HMs4SOZBw==
"@verdaccio/local-storage@2.0.0-beta.2":
version "2.0.0-beta.2"
resolved "https://registry.verdaccio.org/@verdaccio%2flocal-storage/-/local-storage-2.0.0-beta.2.tgz#fff60cdabc847ec9b125a3c2bf51786da6926d45"
integrity sha512-OZrKWe04kBSuqHfPCRCPv7QBA2Lz5+jtPChirHhvSaguZ+a8UqxVgn7lLUNsvchKBQan4r5+4VJKXAh+JicrMg==
dependencies:
"@verdaccio/file-locking" "0.0.7"
"@verdaccio/file-locking" "0.0.8"
"@verdaccio/streams" "2.0.0-beta.0"
async "2.6.1"
async "3.0.1-0"
http-errors "1.7.1"
lodash "4.17.11"
mkdirp "0.5.1"
@ -1793,13 +1793,6 @@ async-limiter@~1.0.0:
resolved "https://registry.verdaccio.org/async-limiter/-/async-limiter-1.0.0.tgz#78faed8c3d074ab81f22b4e985d79e8738f720f8"
integrity sha512-jp/uFnooOiO+L211eZOoSyzpOITMXx1rBITauYykG3BRYPu8h0UcxsPNB04RR5vo4Tyz3+ay17tR6JVf9qzYWg==
async@2.6.1, async@^2.1.4, async@^2.5.0:
version "2.6.1"
resolved "https://registry.verdaccio.org/async/-/async-2.6.1.tgz#b245a23ca71930044ec53fa46aa00a3e87c6a610"
integrity sha512-fNEiL2+AZt6AlAw/29Cr0UDe4sRAHCpEHh54WMz+Bb7QfNcFw4h3loofyJpLeQs4Yx7yuqu/2dLgM5hKOs6HlQ==
dependencies:
lodash "^4.17.10"
async@3.0.1-0:
version "3.0.1-0"
resolved "https://registry.verdaccio.org/async/-/async-3.0.1-0.tgz#ca06713f91c3d9eea3e966ace4093f41ef89f200"
@ -1810,6 +1803,13 @@ async@^1.5.2:
resolved "https://registry.verdaccio.org/async/-/async-1.5.2.tgz#ec6a61ae56480c0c3cb241c95618e20892f9672a"
integrity sha1-7GphrlZIDAw8skHJVhjiCJL5Zyo=
async@^2.1.4, async@^2.5.0:
version "2.6.1"
resolved "https://registry.verdaccio.org/async/-/async-2.6.1.tgz#b245a23ca71930044ec53fa46aa00a3e87c6a610"
integrity sha512-fNEiL2+AZt6AlAw/29Cr0UDe4sRAHCpEHh54WMz+Bb7QfNcFw4h3loofyJpLeQs4Yx7yuqu/2dLgM5hKOs6HlQ==
dependencies:
lodash "^4.17.10"
asynckit@^0.4.0:
version "0.4.0"
resolved "https://registry.verdaccio.org/asynckit/-/asynckit-0.4.0.tgz#c79ed97f7f34cb8f2ba1bc9790bcc366474b4b79"