Merge pull request #676 from verdaccio/fix-673

fix: allow do not include storage if uses a storage plugin

src/lib/config.js

@@ -91,9 +91,7 @@ class Config {
     // some weird shell scripts are valid yaml files parsed as string
     assert.equal(typeof(config), 'object', 'CONFIG: it doesn\'t look like a valid config file');
 
-    assert(self.storage, 'CONFIG: storage path not defined');
-
-     // sanity check for strategic config properties
+    // sanity check for strategic config properties
     strategicConfigProps.forEach(function(x) {
       if (self[x] == null) self[x] = {};
       assert(Utils.isObject(self[x]), `CONFIG: bad "${x}" value (object expected)`);

src/lib/local-storage.js

@@ -842,6 +842,7 @@ class LocalStorage implements IStorage {
     const Storage = this._loadStorePlugin();
 
     if (_.isNil(Storage)) {
+      assert(this.config.storage, 'CONFIG: storage path not defined');
       return new LocalDatabase(this.config, logger);
     } else {
       return Storage;

test/e2e/config/config-protected-e2e.yaml

@@ -1,6 +1,3 @@
-# this is useless yet since we use a custom storage, just ignore it
-storage: ./store-e2e
-
 web:
   enable: true
   title: verdaccio-server-protected-e2e

test/e2e/config/config-scoped-e2e.yaml

@@ -1,6 +1,3 @@
-# this is useless yet since we use a custom storage, just ignore it
-storage: ./store-e2e
-
 web:
   enable: true
   title: verdaccio-server-e2e