From 3588df5efd67ee692b16f69a044b8ea4561e8a21 Mon Sep 17 00:00:00 2001
From: Ashish Surana <ashishsurana12345@gmail.com>
Date: Thu, 11 Oct 2018 21:47:02 +0530
Subject: [PATCH] refactor: moving API response to constants (#1069)

- creates TARBALL_UPLOADED & BAD_PACKAGE_DATA constant
---
 src/api/endpoint/api/publish.js | 6 +++---
 src/lib/constants.js            | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/api/endpoint/api/publish.js b/src/api/endpoint/api/publish.js
index cd2f3029b..a85d58027 100644
--- a/src/api/endpoint/api/publish.js
+++ b/src/api/endpoint/api/publish.js
@@ -7,7 +7,7 @@ import _ from 'lodash';
 import Path from 'path';
 import mime from 'mime';
 
-import { API_MESSAGE, HEADERS, DIST_TAGS } from '../../../lib/constants';
+import { API_MESSAGE, HEADERS, DIST_TAGS, API_ERROR } from '../../../lib/constants';
 import { validateMetadata, isObject, ErrorCode } from '../../../lib/utils';
 import { media, expectJson, allow } from '../../middleware';
 import { notify } from '../../../lib/notify';
@@ -121,7 +121,7 @@ export default function(router: Router, auth: IAuth, storage: IStorageHandler, c
     try {
       metadata = validateMetadata(req.body, name);
     } catch (err) {
-      return next(ErrorCode.getBadData('bad incoming package data'));
+      return next(ErrorCode.getBadData(API_ERROR.BAD_PACKAGE_DATA));
     }
 
     if (req.params._rev) {
@@ -187,7 +187,7 @@ export default function(router: Router, auth: IAuth, storage: IStorageHandler, c
     stream.on('success', function() {
       res.status(201);
       return next({
-        ok: 'tarball uploaded successfully',
+        ok: API_MESSAGE.TARBALL_UPLOADED,
       });
     });
   });
diff --git a/src/lib/constants.js b/src/lib/constants.js
index 99a31bac9..d784b5d9b 100644
--- a/src/lib/constants.js
+++ b/src/lib/constants.js
@@ -79,6 +79,7 @@ export const API_MESSAGE = {
   PKG_CHANGED: 'package changed',
   PKG_REMOVED: 'package removed',
   PKG_PUBLISHED: 'package published',
+  TARBALL_UPLOADED: 'tarball uploaded successfully',
   TARBALL_REMOVED: 'tarball removed',
   TAG_UPDATED: 'tags updated',
   TAG_REMOVED: 'tag removed',
@@ -110,6 +111,7 @@ export const API_ERROR = {
   DEPRECATED_BASIC_HEADER: 'basic authentication is deprecated, please use JWT instead',
   BAD_FORMAT_USER_GROUP: 'user groups is different than an array',
   RESOURCE_UNAVAILABLE: 'resource unavailable',
+  BAD_PACKAGE_DATA: 'bad incoming package data',
 };
 
 export const APP_ERROR = {