Nick 3d9ed62f4a Reenable creating default webhooks. (#24626) ... Fixes #24624 This seems to have been broken in https://github.com/go-gitea/gitea/pull/21563 Previously, this code read ``` // Are we looking at default webhooks? if ctx.Params(":configType") == "default-hooks" { return &orgRepoCtx{ IsAdmin: true, Link: path.Join(setting.AppSubURL, "/admin/hooks"), LinkNew: path.Join(setting.AppSubURL, "/admin/default-hooks"), NewTemplate: tplAdminHookNew, }, nil } // Must be system webhooks instead return &orgRepoCtx{ IsAdmin: true, IsSystemWebhook: true, Link: path.Join(setting.AppSubURL, "/admin/hooks"), LinkNew: path.Join(setting.AppSubURL, "/admin/system-hooks"), NewTemplate: tplAdminHookNew, }, nil ``` but was simplified to ``` return &ownerRepoCtx{ IsAdmin: true, IsSystemWebhook: ctx.Params(":configType") == "system-hooks", Link: path.Join(setting.AppSubURL, "/admin/hooks"), LinkNew: path.Join(setting.AppSubURL, "/admin/system-hooks"), NewTemplate: tplAdminHookNew, }, nil ``` In other words, combining the `IsSystemWebhook` check into a one-liner and forgetting that `LinkNew` also depended on it. This meant the rendered `<form>` always POSTed to `/admin/system-hooks`, even when you had GETed `/admin/default-hooks/gitea/new`.		2023-05-11 10:10:57 +08:00
..
api	Improve updating Actions tasks (#24600)	2023-05-10 13:54:18 +02:00
common	Make repository response support HTTP range request (#24592)	2023-05-09 15:34:36 +08:00
install	Improve template system and panic recovery (#24461)	2023-05-04 14:36:34 +08:00
private	Refactor web route (#24080)	2023-04-20 14:49:06 -04:00
utils	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
web	Reenable creating default webhooks. (#24626)	2023-05-11 10:10:57 +08:00
init.go	Use globally shared HTMLRender (#24436)	2023-04-30 08:22:23 -04:00