github.com/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2024-11-10 11:35:52 +01:00
Code Releases Wiki Activity

fix: don't allow blank space in collab name (#6211)

Browse Source 
* don't allow blank space in collab name

* add spec

* prevent blank
This commit is contained in:
Aakansha Doshi 2023-02-09 15:51:49 +05:30 committed by GitHub
parent 8c1168ef33
commit c9d18ecab6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/clients.ts
View File

@ -21,7 +21,7 @@ export const getClientColors = (clientId: string, appState: AppState) => {
}; };
export const getClientInitials = (userName?: string | null) => { export const getClientInitials = (userName?: string | null) => {
if (!userName) { if (!userName?.trim()) {
return "?"; return "?";
} }
return userName.trim()[0].toUpperCase(); return userName.trim()[0].toUpperCase();

2
src/excalidraw-app/collab/RoomDialog.tsx
View File

@ -144,7 +144,7 @@ const RoomDialog = ({
<input <input
type="text" type="text"
id="username" id="username"
value={username || ""} value={username.trim() || ""}
className="RoomDialog-username TextInput" className="RoomDialog-username TextInput"
onChange={(event) => onUsernameChange(event.target.value)} onChange={(event) => onUsernameChange(event.target.value)}
onKeyPress={(event) => event.key === "Enter" && handleClose()} onKeyPress={(event) => event.key === "Enter" && handleClose()}

5
src/tests/clients.test.ts
View File

@ -36,4 +36,9 @@ describe("getClientInitials", () => {
result = getClientInitials(null); result = getClientInitials(null);
expect(result).toBe("?"); expect(result).toBe("?");
}); });
it('returns "?" when value is blank', () => {
const result = getClientInitials(" ");
expect(result).toBe("?");
});
}); });