github.com
/
excalidraw
mirror of https://github.com/excalidraw/excalidraw.git
1
0
Fork 0
Code Releases Wiki Activity

Fixed wysiwyg carret disappearing on Chrome (#652) 

There's a bug where the carret doesn't show up when the text is first focused on Chrome with the previous combination of CSS. I tweaked it and now it seems to work (don't ask me why!).

Unfortunately on Safari, ever since we moved to contentEditable on #274, the carret disappeared the first time. I unsuccessfully tried to repro in a smaller codebase ( https://jsfiddle.net/u2mjs90y/1/ ) but it does work in Safari...

I'm not exactly sure what's going on, there are bunch of issues opened against this bug when googling against all the browsers...
This commit is contained in:
Christopher Chedeau 2020-02-01 05:54:33 +00:00 committed by GitHub
parent 70db792549
commit 9a76556bea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/element/textWysiwyg.tsx
View File

@ -39,7 +39,7 @@ export function textWysiwyg({
Object.assign(editable.style, { Object.assign(editable.style, {
color: strokeColor, color: strokeColor,
position: "fixed", position: "absolute",
opacity: opacity / 100, opacity: opacity / 100,
top: y + "px", top: y + "px",
left: x + "px", left: x + "px",

4
src/styles.scss
View File

@ -3,6 +3,10 @@
body { body {
margin: 0; margin: 0;
font-family: Arial, Helvetica, sans-serif; font-family: Arial, Helvetica, sans-serif;
overflow: hidden;
position: fixed;
width: 100%;
height: 100%;
color: var(--text-color-primary); color: var(--text-color-primary);
} }