github.com/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-02-18 13:29:36 +01:00
Code Releases Wiki Activity

fix: View mode wheel zooming does not work (#8452)

Browse Source 
* Update App.tsx

* fix: prevent zooming browser over DOM

---------

Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
This commit is contained in:
zsviczian 2024-08-31 12:06:38 +02:00 committed by GitHub
parent ee30225062
commit 2d1d84a47b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/excalidraw/components/App.tsx
View File

@ -2515,7 +2515,7 @@ class App extends React.Component<AppProps, AppState> {
addEventListener( addEventListener(
this.excalidrawContainerRef.current, this.excalidrawContainerRef.current,
EVENT.WHEEL, EVENT.WHEEL,
this.onWheel, this.handleWheel,
{ passive: false }, { passive: false },
), ),
addEventListener(window, EVENT.MESSAGE, this.onWindowMessage, false), addEventListener(window, EVENT.MESSAGE, this.onWindowMessage, false),
@ -4323,13 +4323,6 @@ class App extends React.Component<AppProps, AppState> {
}, },
); );
private onWheel = withBatchedUpdates((event: WheelEvent) => {
// prevent browser pinch zoom on DOM elements
if (!(event.target instanceof HTMLCanvasElement) && event.ctrlKey) {
event.preventDefault();
}
});
private onKeyUp = withBatchedUpdates((event: KeyboardEvent) => { private onKeyUp = withBatchedUpdates((event: KeyboardEvent) => {
if (event.key === KEYS.SPACE) { if (event.key === KEYS.SPACE) {
if (this.state.viewModeEnabled) { if (this.state.viewModeEnabled) {
@ -10089,6 +10082,11 @@ class App extends React.Component<AppProps, AppState> {
event.target instanceof HTMLIFrameElement event.target instanceof HTMLIFrameElement
) )
) { ) {
// prevent zooming the browser (but allow scrolling DOM)
if (event[KEYS.CTRL_OR_CMD]) {
event.preventDefault();
}
return; return;
} }