1
0
mirror of https://github.com/distribution/distribution synced 2024-11-12 05:45:51 +01:00
distribution/registry
Aaron Lehmann 31047c8113 Simplify digest.FromBytes calling convention
The current implementation of digest.FromBytes returns an error. This
error can never be non-nil, but its presence in the function signature
means each call site needs error handling code for an error that is
always nil.

I verified that none of the hash.Hash implementations in the standard
library can return an error on Write. Nor can any of the hash.Hash
implementations vendored in distribution.

This commit changes digest.FromBytes not to return an error. If Write
returns an error, it will panic, but as discussed above, this should
never happen.

This commit also avoids using a bytes.Reader to feed data into the hash
function in FromBytes. This makes the hypothetical case that would panic
a bit more explicit, and should also be more performant.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2015-12-14 14:30:51 -08:00
..
api Fix failing test case 2015-10-25 13:03:22 -04:00
auth De-obfuscate error message 2015-11-06 17:10:28 -08:00
client Simplify digest.FromBytes calling convention 2015-12-14 14:30:51 -08:00
handlers Simplify digest.FromBytes calling convention 2015-12-14 14:30:51 -08:00
listener [Server] Listen and serve on a unix socket 2015-05-11 16:00:14 +03:00
middleware Add pull through cache functionality to the Registry which can be configured 2015-08-04 16:09:55 -07:00
proxy Simplify digest.FromBytes calling convention 2015-12-14 14:30:51 -08:00
storage Simplify digest.FromBytes calling convention 2015-12-14 14:30:51 -08:00
doc.go Move initialization code from main.go to the registry package 2015-09-09 14:39:31 -07:00
registry.go Add WithVersion to context and other cleanup 2015-09-14 17:14:31 -07:00