mirror of
https://github.com/distribution/distribution
synced 2025-02-23 06:49:36 +01:00
2074688be9
The loop that iterates over paginated lists of S3 multipart upload parts
appears to be using the wrong variable in its loop condition. Nothing
inside the loop affects the value of `resp.IsTruncated`, so this loop
will either be wrongly skipped or loop forever.
It looks like this is a regression caused by commit
7736319f2ed49768b9d9eb832465a1317dd0b106. The return value of
`ListMultipartUploads` used to be assigned to a variable named `resp`,
but it was renamed to `partsList` without updating the for loop
condition.
I believe this is causing an error we're seeing with large layer uploads
at commit time:
upload resumed at wrong offset: 5242880000 != 5815706782
Missing parts of the multipart S3 upload would cause an incorrect size
calculation in `newWriter`.
Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
|
||
|---|---|---|
| .. | ||
| api | ||
| auth | ||
| client | ||
| handlers | ||
| listener | ||
| middleware | ||
| proxy | ||
| storage | ||
| doc.go | ||
| registry_test.go | ||
| registry.go | ||
| root.go | ||