distribution/dockerfiles/lint.Dockerfile

# syntax=docker/dockerfile:1

ARG GO_VERSION=1.19.10
ARG ALPINE_VERSION=3.18
ARG GOLANGCI_LINT_VERSION=v1.52
ARG BUILDTAGS="include_gcs"

FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint

FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base
RUN apk add --no-cache gcc musl-dev
WORKDIR /src

FROM base
ENV GOFLAGS="-buildvcs=false"
RUN --mount=type=bind,target=. \
    --mount=type=cache,target=/root/.cache \
    --mount=from=golangci-lint,source=/usr/bin/golangci-lint,target=/usr/bin/golangci-lint \
      golangci-lint --build-tags "${BUILDTAGS}" run
lint target and workflow job Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-05-03 12:51:31 +02:00			`# syntax=docker/dockerfile:1`

Update to golang 1.19.10 This addresses CVE-2023-29402, CVE-2023-29403, CVE-2023-29404, CVE-2023-29405 which were patched in 1.19.10. Signed-off-by: Ben Manuel <ben.manuel@procore.com> 2023-06-29 22:34:00 +02:00			`ARG GO_VERSION=1.19.10`
			`ARG ALPINE_VERSION=3.18`
update golangci-lint to v1.52 Removing the "structcheck" and "varcheck" linters as they've been deprecated. level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused." level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused." Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-05-09 12:36:32 +02:00			`ARG GOLANGCI_LINT_VERSION=v1.52`
Remove oss storage driver and alicdn storage driver middleware This commit removes `oss` storage driver from distribution as well as `alicdn` storage middleware which only works with the `oss` driver. There are several reasons for it: * no real-life expertise among the maintainers * oss is compatible with S3 API operations required by S3 storage driver Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com> 2023-08-16 09:39:20 +02:00			`ARG BUILDTAGS="include_gcs"`
lint target and workflow job Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-05-03 12:51:31 +02:00
			`FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint`

dockerfiles: set ALPINE_VERSION Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-07-20 14:19:39 +02:00			`FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base`
lint target and workflow job Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-05-03 12:51:31 +02:00			`RUN apk add --no-cache gcc musl-dev`
			`WORKDIR /src`

			`FROM base`
update to go 1.18 (continue testing against 1.17) Go 1.16 reached end of life, so update to the current version of Go, but also run CI on the previous version (which is still supported). We should probably also decide wether or not we want the Dockerfiles to pin to a specific minor version; this makes the releases more deterministic. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-05-05 10:20:56 +02:00			`ENV GOFLAGS="-buildvcs=false"`
lint target and workflow job Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-05-03 12:51:31 +02:00			`RUN --mount=type=bind,target=. \`
dockerfiles: formatting Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-07-20 16:44:31 +02:00			`--mount=type=cache,target=/root/.cache \`
			`--mount=from=golangci-lint,source=/usr/bin/golangci-lint,target=/usr/bin/golangci-lint \`
Enable Go build tags This enables go build tags so the GCS and OSS driver support is available in the binary distributed via the image build by Dockerfile. This led to quite a few fixes in the GCS and OSS packages raised as warning by golang-ci linter. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com> 2023-06-28 12:41:22 +02:00			`golangci-lint --build-tags "${BUILDTAGS}" run`